----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45998/#review128064 -----------------------------------------------------------
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/files/templetonSmoke.sh (line 59) <https://reviews.apache.org/r/45998/#comment191450> /tmp/show_db.post.txt is this a path in local filesystem? If yes, we should use agent tmp_dir, because some users has non-executable tmp. You will have to get it from params.tmp_dir and pass it into script. - Andrew Onischuk On April 11, 2016, 3:07 a.m., Masahiro Tanaka wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45998/ > ----------------------------------------------------------- > > (Updated April 11, 2016, 3:07 a.m.) > > > Review request for Ambari, Andrew Onischuk, Jaimin Jetly, and Nate Cole. > > > Repository: ambari > > > Description > ------- > > In templetonSmoke.sh, there are > 1) unnecessary `exit 0` > 2) lack of redirect `>` command > 3) unassigned variable > > we should correct them all to check the HIVE service properly. > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/files/templetonSmoke.sh > dd00e02 > > Diff: https://reviews.apache.org/r/45998/diff/ > > > Testing > ------- > > mvn clean test and manual test with HDP2.4 and Ambari 2.2.1.0 > > > Thanks, > > Masahiro Tanaka > >
