> On April 11, 2016, 4:21 a.m., Andrew Onischuk wrote: > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/files/templetonSmoke.sh, > > line 84 > > <https://reviews.apache.org/r/45998/diff/1/?file=1338554#file1338554line84> > > > > I wonder where this $destdir variable comes from > > Andrew Onischuk wrote: > or was it not working at all?
Thank you for reviewing, I guess this code was not working at all because of `exit 0`... - Masahiro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45998/#review128062 ----------------------------------------------------------- On April 11, 2016, 3:07 a.m., Masahiro Tanaka wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45998/ > ----------------------------------------------------------- > > (Updated April 11, 2016, 3:07 a.m.) > > > Review request for Ambari, Andrew Onischuk, Jaimin Jetly, and Nate Cole. > > > Repository: ambari > > > Description > ------- > > In templetonSmoke.sh, there are > 1) unnecessary `exit 0` > 2) lack of redirect `>` command > 3) unassigned variable > > we should correct them all to check the HIVE service properly. > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/files/templetonSmoke.sh > dd00e02 > > Diff: https://reviews.apache.org/r/45998/diff/ > > > Testing > ------- > > mvn clean test and manual test with HDP2.4 and Ambari 2.2.1.0 > > > Thanks, > > Masahiro Tanaka > >
