----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46148/ -----------------------------------------------------------
Review request for Ambari, Laszlo Puskas, Oliver Szabo, Sandor Magyari, and Sebastian Toader. Bugs: AMBARI-15862 https://issues.apache.org/jira/browse/AMBARI-15862 Repository: ambari Description ------- When deleting a host, NPE may occur. TopologyHostRequests are created with hostName=null at the first time, and when hosts are registered, then these null values are replaced with the correct host names. In the case when a host is being deleted, a loop checks the host name for all the requests, and if there is a request with hostName=null, a NPE is thrown. Swapping the sides of **equals** method can solve the problem, since the variable **hostname** is checked before and not null. Diffs ----- ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java caab7df Diff: https://reviews.apache.org/r/46148/diff/ Testing ------- Thanks, Daniel Gergely