> On April 14, 2016, 3:33 a.m., Alexander Denissov wrote: > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py, > > line 92 > > <https://reviews.apache.org/r/46186/diff/1/?file=1343689#file1343689line92> > > > > I think this function should only take a name of component and use > > utility to get process name and port number based on metadata. Maybe > > refactor that function from status into utils ?
PROCESS_INFO(now renamed to COMPONENT_ATTRIBUTES) holds port property names but not port numbers themselve. And a old port and a new port can be different depending on where it is from (either from Ambari or local hawq-site.xml) The source can be determined by action(whether it is start or stop). so here is too much dependencies. This function should only form a string of netstat so I'd rather not to have the logic. (I'd replace the if statement with PROCESS_INFO though) - jun ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46186/#review128826 ----------------------------------------------------------- On April 14, 2016, 2:19 a.m., jun aoki wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46186/ > ----------------------------------------------------------- > > (Updated April 14, 2016, 2:19 a.m.) > > > Review request for Ambari. > > > Bugs: AMBARI-15852 > https://issues.apache.org/jira/browse/AMBARI-15852 > > > Repository: ambari > > > Description > ------- > > HAWQ restart after port change will fail because Ambari looks for a currently > running process with a new port number. > This change is to make Ambari to look for an older port value. > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py > 413cf1a > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqmaster.py > f2ec914 > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqsegment.py > 636dcad > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstandby.py > 67d1cb0 > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstatus.py > 92ac0af > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/utils.py > 0baa4c5 > ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py c18941c > ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqsegment.py 17d7473 > ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py 44565b3 > > Diff: https://reviews.apache.org/r/46186/diff/ > > > Testing > ------- > > Unit test has passed. > Manual Test in progress. > > > Thanks, > > jun aoki > >
