----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46169/#review129037 -----------------------------------------------------------
Ship it! Ship It! - Jayush Luniya On April 14, 2016, 2:30 p.m., Ajit Kumar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46169/ > ----------------------------------------------------------- > > (Updated April 14, 2016, 2:30 p.m.) > > > Review request for Ambari, Jayush Luniya, Nate Cole, and Sumit Mohanty. > > > Bugs: AMBARI-15870 > https://issues.apache.org/jira/browse/AMBARI-15870 > > > Repository: ambari > > > Description > ------- > > To implement dry-run version of an API, request needs to be parsed manually > to figure out if request has dry-run directive. > It will be good to add a method on Request object method itself which > centralizes parsing and logic for figuring out dry-run directive > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/api/resources/VersionDefinitionResourceDefinition.java > 12b91e3 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestImpl.java > f27f621 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java > f8f8290 > > ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Request.java > 50eed9a > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestImplTest.java > 93fe36f > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestResourceProviderTest.java > ea4afde > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProviderTest.java > 633815e > > Diff: https://reviews.apache.org/r/46169/diff/ > > > Testing > ------- > > Hadoop QA commented on AMBARI-15870: > ------------------------------------ > > {color:green}+1 overall{color}. Here are the results of testing the latest > attachment > http://issues.apache.org/jira/secure/attachment/12798670/rb46169.patch > against trunk revision . > > {color:green}+1 @author{color}. The patch does not contain any @author > tags. > > {color:green}+1 tests included{color}. The patch appears to include 3 > new or modified test files. > > {color:green}+1 javac{color}. The applied patch does not increase the > total number of javac compiler warnings. > > {color:green}+1 release audit{color}. The applied patch does not > increase the total number of release audit warnings. > > {color:green}+1 core tests{color}. The patch passed unit tests in > ambari-server. > > Test results: > https://builds.apache.org/job/Ambari-trunk-test-patch/6435//testReport/ > Console output: > https://builds.apache.org/job/Ambari-trunk-test-patch/6435//console > > > Thanks, > > Ajit Kumar > >
