> On Апрель 18, 2016, 1:39 п.п., Robert Nettleton wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java,
> >  line 858
> > <https://reviews.apache.org/r/46327/diff/1/?file=1348454#file1348454line858>
> >
> >     Why is this internal property being checked here?  
> >     
> >     The update change above seems to indicate that these properties should 
> > always be set to the same values.  If that is the case, then why is this 
> > method being modified?

We only add "dfs.internal.nameservices" if it's not specified in user's 
blueprint and always rely on "dfs.internal.nameservices" instead of 
"dfs.nameservices". "dfs.nameservices" might contain external name services, 
not managed by Ambari
if (clusterTopology.isNameNodeHAEnabled()) {

      // add "dfs.internal.nameservices" if it's not specified
      Map<String, String> hdfsSiteConfig = 
clusterConfig.getFullProperties().get("hdfs-site");
      String nameservices = hdfsSiteConfig.get("dfs.nameservices");
      String int_nameservices = hdfsSiteConfig.get("dfs.internal.nameservices");
      if(int_nameservices == null && nameservices != null) {
        clusterConfig.setProperty("hdfs-site", "dfs.internal.nameservices", 
nameservices);
      }


- Dmytro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46327/#review129331
-----------------------------------------------------------


On Апрель 18, 2016, 1:39 п.п., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46327/
> -----------------------------------------------------------
> 
> (Updated Апрель 18, 2016, 1:39 п.п.)
> 
> 
> Review request for Ambari, John Speidel and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-15791
>     https://issues.apache.org/jira/browse/AMBARI-15791
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Blueprint config processing engine should automatically populate 
> dfs.internal.nameservices when it is deploying HA clusters. The work-around 
> till then is to explicitly add the property when submitting the blueprint.
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  1433a1b 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
>  834953b 
> 
> Diff: https://reviews.apache.org/r/46327/diff/
> 
> 
> Testing
> -------
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Reply via email to