> On April 20, 2016, 6:30 p.m., Alejandro Fernandez wrote:
> > ambari-agent/src/main/python/ambari_agent/ClusterConfiguration.py, line 132
> > <https://reviews.apache.org/r/46420/diff/1/?file=1352656#file1352656line132>
> >
> >     I thought entire /var/lib/ambari-agent folder was protected so this was 
> > not needed.

I just checked and I do not see /var/lib/ambari-agent protected. To rule out a 
packaging issue I checked with a HDP 2.3 cluster as well and all parent 
directories of configurations.json

-rw-r--r-- 1 root root 209821 Apr 18 13:05 
/var/lib/ambari-agent/cache/cluster_configuration/configurations.json
drwxr-xr-x 2 root root 4096 Apr 12 21:06 
/var/lib/ambari-agent/cache/cluster_configuration
drwxr-xr-x 9 root root 4096 Apr 12 21:02 /var/lib/ambari-agent/cache
drwxr-xr-x 7 root root 4096 Apr 12 21:01 /var/lib/ambari-agent

Am I missing something?


- Shantanu


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46420/#review129764
-----------------------------------------------------------


On April 20, 2016, 2:57 a.m., Shantanu Mundkur wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46420/
> -----------------------------------------------------------
> 
> (Updated April 20, 2016, 2:57 a.m.)
> 
> 
> Review request for Ambari and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15496
>     https://issues.apache.org/jira/browse/AMBARI-15496
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Various passwords are in plain text in world readable configurations.json file
> 
> $ ls -altr 
> /var/lib/ambari-agent/cache/cluster_configuration/configurations.json
> 
> rw-rr- 1 root root 176342 Mar 4 08:55 
> /var/lib/ambari-agent/cache/cluster_configuration/configurations.json
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/ClusterConfiguration.py 8d3b6f0 
>   ambari-agent/src/test/python/ambari_agent/TestAlerts.py c13b472 
>   ambari-agent/src/test/python/ambari_agent/TestClusterConfigurationCache.py 
> e82fca2 
> 
> Diff: https://reviews.apache.org/r/46420/diff/
> 
> 
> Testing
> -------
> 
> 1) Tried root and non-root installations and verified the permissions on the 
> /var/lib/ambari-agent/cache/cluster_configuration/configurations.json on each 
> node.
> 
> 2) mvn test under ambari-agent
> 
> Ran 426 tests in 9.817s
> 
> FAILED (failures=9)
> 
> All Failures unrelated to the change:
> 
> test_action_create_existent (TestUserResource.TestUserResource) ... FAIL
> test_action_create_nonexistent (TestUserResource.TestUserResource) ... FAIL
> test_attribute_comment (TestUserResource.TestUserResource) ... FAIL
> test_attribute_gid (TestUserResource.TestUserResource) ... FAIL
> test_attribute_home (TestUserResource.TestUserResource) ... FAIL
> test_attribute_password (TestUserResource.TestUserResource) ... FAIL
> test_attribute_shell (TestUserResource.TestUserResource) ... FAIL
> test_attribute_uid (TestUserResource.TestUserResource) ... FAIL
> test_missing_shell_argument (TestUserResource.TestUserResource) ... FAIL
> 
> 
> Thanks,
> 
> Shantanu Mundkur
> 
>

Reply via email to