-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46420/
-----------------------------------------------------------

Review request for Ambari and Yusaku Sako.


Bugs: AMBARI-15496
    https://issues.apache.org/jira/browse/AMBARI-15496


Repository: ambari


Description
-------

Various passwords are in plain text in world readable configurations.json file

$ ls -altr /var/lib/ambari-agent/cache/cluster_configuration/configurations.json

rw-rr- 1 root root 176342 Mar 4 08:55 
/var/lib/ambari-agent/cache/cluster_configuration/configurations.json


Diffs
-----

  ambari-agent/src/main/python/ambari_agent/ClusterConfiguration.py 8d3b6f0 
  ambari-agent/src/test/python/ambari_agent/TestAlerts.py c13b472 
  ambari-agent/src/test/python/ambari_agent/TestClusterConfigurationCache.py 
e82fca2 

Diff: https://reviews.apache.org/r/46420/diff/


Testing
-------

1) Tried root and non-root installations and verified the permissions on the 
/var/lib/ambari-agent/cache/cluster_configuration/configurations.json on each 
node.

2) mvn test under ambari-agent

Ran 426 tests in 9.817s

FAILED (failures=9)

All Failures unrelated to the change:

test_action_create_existent (TestUserResource.TestUserResource) ... FAIL
test_action_create_nonexistent (TestUserResource.TestUserResource) ... FAIL
test_attribute_comment (TestUserResource.TestUserResource) ... FAIL
test_attribute_gid (TestUserResource.TestUserResource) ... FAIL
test_attribute_home (TestUserResource.TestUserResource) ... FAIL
test_attribute_password (TestUserResource.TestUserResource) ... FAIL
test_attribute_shell (TestUserResource.TestUserResource) ... FAIL
test_attribute_uid (TestUserResource.TestUserResource) ... FAIL
test_missing_shell_argument (TestUserResource.TestUserResource) ... FAIL


Thanks,

Shantanu Mundkur

Reply via email to