-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46484/#review129891
-----------------------------------------------------------




ambari-server/src/main/java/org/apache/ambari/server/checks/HealthCheck.java 
(line 74)
<https://reviews.apache.org/r/46484/#comment193443>

    CLUSTER type checks typically don't have hosts on getFailedOn() (at least, 
that's not the intent).  SERVICE types get service names, HOST types get host 
names.


- Nate Cole


On April 21, 2016, 7:14 a.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46484/
> -----------------------------------------------------------
> 
> (Updated April 21, 2016, 7:14 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Jonathan 
> Hurley, and Nate Cole.
> 
> 
> Bugs: AMBARI-16005
>     https://issues.apache.org/jira/browse/AMBARI-16005
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Enhance Health Check for the Cluster before upgrading.
> 
> * check for alerts (perhaps don't start RU/EU if any blocker alerts).
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java
>  3e957b1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/HealthCheck.java 
> PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/HealthCheckTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46484/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Reply via email to