> On April 21, 2016, 8:57 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/java/org/apache/ambari/server/checks/HealthCheck.java, > > line 67 > > <https://reviews.apache.org/r/46484/diff/1/?file=1354793#file1354793line67> > > > > I thought we were going to filter for only a handful of alerts based on > > the name. > > E.g., out of disk space, ambari performance, etc.
Finally we decided to warn about all alerts (as stated by Jonathan in last comment of jira) - Dmitro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46484/#review129931 ----------------------------------------------------------- On April 21, 2016, 2:14 p.m., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46484/ > ----------------------------------------------------------- > > (Updated April 21, 2016, 2:14 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Jonathan > Hurley, and Nate Cole. > > > Bugs: AMBARI-16005 > https://issues.apache.org/jira/browse/AMBARI-16005 > > > Repository: ambari > > > Description > ------- > > Enhance Health Check for the Cluster before upgrading. > > * check for alerts (perhaps don't start RU/EU if any blocker alerts). > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java > 3e957b1 > > ambari-server/src/main/java/org/apache/ambari/server/checks/HealthCheck.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/checks/HealthCheckTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/46484/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Dmitro Lisnichenko > >
