----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46445/#review130152 -----------------------------------------------------------
Fix it, then Ship it! ambari-common/src/main/python/resource_management/libraries/script/script.py <https://reviews.apache.org/r/46445/#comment193833> Should add "pass" for it to be a complete function - Alejandro Fernandez On April 20, 2016, 4:35 p.m., Juanjo Marron wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46445/ > ----------------------------------------------------------- > > (Updated April 20, 2016, 4:35 p.m.) > > > Review request for Ambari, Alejandro Fernandez and Jayush Luniya. > > > Bugs: AMBARI-15609 > https://issues.apache.org/jira/browse/AMBARI-15609 > > > Repository: ambari > > > Description > ------- > > The original intention of the get_stack_to_component function was to have a > dictionary where the key was the stack name. > At service level we always return the same key no matter what, then we should > just return the string with the component name and no need to check > params.stack_name > > > Diffs > ----- > > > ambari-common/src/main/python/resource_management/libraries/script/script.py > 31d7b2a > > ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_client.py > ebfacf2 > > ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_script.py > 1004d23 > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/atlas_client.py > 14a12d3 > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata_server.py > a5990a2 > > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_client.py > 75b5de4 > > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server.py > 86bf3b6 > > ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume_handler.py > 1bd99da > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_client.py > b72e648 > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py > 5833773 > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_regionserver.py > 37dd0a1 > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/phoenix_queryserver.py > 7d639ec > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py > ffaf4ea > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_client.py > 9f62d29 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode.py > ac73eaf > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py > c8acae3 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/nfsgateway.py > ca2e3ef > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/snamenode.py > 4a6f144 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_client.py > 6c41fc2 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_client.py > 6af0cd3 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py > 8adff0a > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py > 9ba8619 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py > 9d011a0 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_server.py > 482f0be > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/kafka_broker.py > 41074db > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox_gateway.py > aa5ce1f > > ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/mahout_client.py > d39b66a > > ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_client.py > dc08f0b > > ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py > c7107c9 > > ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/pig_client.py > 81db437 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py > 8e41c2c > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_tagsync.py > 79316f9 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_usersync.py > 675e798 > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_server.py > d8822c1 > > ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/slider_client.py > af08a51 > > ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/job_history_server.py > 1041a75 > > ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/spark_client.py > e2ec952 > > ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/spark_thrift_server.py > 3c32236 > > ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/service_check.py > f4f0302 > > ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/sqoop_client.py > 0e5fd1d > > ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/drpc_server.py > 1f88898 > > ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py > b700349 > > ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/nimbus_prod.py > 1956120 > > ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/rest_api.py > e080794 > > ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/supervisor.py > bd9aade > > ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/supervisor_prod.py > aa79ee3 > > ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/ui_server.py > c7a62d9 > > ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/tez_client.py > ca13c6e > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/application_timeline_server.py > fdb5be5 > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py > e9ee529 > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapreduce2_client.py > 16f43dc > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/nodemanager.py > dd6b130 > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py > 141b11a > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn_client.py > 1fdd9d6 > > ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_client.py > 3043c45 > > ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_server.py > fee0e83 > > Diff: https://reviews.apache.org/r/46445/diff/ > > > Testing > ------- > > mvn clean test -DskipSurefireTests > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Ambari Main ....................................... SUCCESS [52.199s] > [INFO] Apache Ambari Project POM ......................... SUCCESS [1.008s] > [INFO] Ambari Web ........................................ SUCCESS [1:55.020s] > [INFO] Ambari Views ...................................... SUCCESS [10.201s] > [INFO] Ambari Admin View ................................. SUCCESS [28.427s] > [INFO] ambari-metrics .................................... SUCCESS [1.984s] > [INFO] Ambari Metrics Common ............................. SUCCESS [2.614s] > [INFO] Ambari Metrics Hadoop Sink ........................ SUCCESS [3.273s] > [INFO] Ambari Metrics Flume Sink ......................... SUCCESS [1.014s] > [INFO] Ambari Metrics Kafka Sink ......................... SUCCESS [1.121s] > [INFO] Ambari Metrics Storm Sink ......................... SUCCESS [3.095s] > [INFO] Ambari Metrics Collector .......................... SUCCESS [44.049s] > [INFO] Ambari Metrics Monitor ............................ SUCCESS [4.723s] > [INFO] Ambari Metrics Grafana ............................ SUCCESS [25.620s] > [INFO] Ambari Metrics Assembly ........................... SUCCESS [46.641s] > [INFO] Ambari Server ..................................... SUCCESS [2:37.916s] > [INFO] Ambari Functional Tests ........................... SUCCESS [2.405s] > [INFO] Ambari Agent ...................................... SUCCESS [17.269s] > [INFO] Ambari Client ..................................... SUCCESS [0.428s] > [INFO] Ambari Python Client .............................. SUCCESS [1.825s] > [INFO] Ambari Groovy Client .............................. SUCCESS [22.088s] > [INFO] Ambari Shell ...................................... SUCCESS [0.389s] > [INFO] Ambari Python Shell ............................... SUCCESS [0.116s] > [INFO] Ambari Groovy Shell ............................... SUCCESS [13.794s] > [INFO] ambari-logsearch .................................. SUCCESS [2.336s] > [INFO] Ambari Logsearch Portal ........................... SUCCESS [8.900s] > [INFO] Ambari Logsearch Log Feeder ....................... SUCCESS [2.282s] > [INFO] Ambari Logsearch Appender ......................... SUCCESS [0.502s] > [INFO] Ambari Logsearch Assembly ......................... SUCCESS [0.425s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 9:34.234s > [INFO] Finished at: Tue Apr 19 17:05:47 PDT 2016 > [INFO] Final Memory: 124M/560M > > > Additionally Build #6552 was successful: > https://builds.apache.org/job/Ambari-trunk-test-patch/6552/ > > > Thanks, > > Juanjo Marron > >
