-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46445/
-----------------------------------------------------------
(Updated April 22, 2016, 10:54 p.m.)
Review request for Ambari, Alejandro Fernandez and Jayush Luniya.
Bugs: AMBARI-15609
https://issues.apache.org/jira/browse/AMBARI-15609
Repository: ambari
Description
-------
The original intention of the get_stack_to_component function was to have a
dictionary where the key was the stack name.
At service level we always return the same key no matter what, then we should
just return the string with the component name and no need to check
params.stack_name
Diffs (updated)
-----
ambari-common/src/main/python/resource_management/libraries/script/script.py
193138b
ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_client.py
8f94a59
ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_script.py
e210a11
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/atlas_client.py
3715e61
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata_server.py
ae760cb
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_client.py
fa869be
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server.py
d4935fe
ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume_handler.py
cf8d864
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_client.py
b56efa2
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py
4b4a876
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_regionserver.py
4efa739
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/phoenix_queryserver.py
93816e3
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py
1e0c605
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_client.py
e3b0070
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode.py
9929b02
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py
bb6f1ca
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/nfsgateway.py
65cc4fb
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/snamenode.py
c8ec843
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_client.py
99c214d
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_client.py
a87042a
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py
ee82e79
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py
bea00ed
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
fe05ff6
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_server.py
6924040
ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/kafka_broker.py
5f22bba
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox_gateway.py
0a37161
ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/mahout_client.py
1fa4625
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_client.py
d7e9e4d
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py
31cf9e9
ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/pig_client.py
90a5514
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py
66ae76e
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_tagsync.py
43ecd07
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_usersync.py
2382d9c
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_server.py
e13affc
ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/slider_client.py
ba76259
ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/job_history_server.py
7a7f086
ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/spark_client.py
740c442
ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/spark_thrift_server.py
f3742be
ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/service_check.py
30184d9
ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/sqoop_client.py
0e5fd1d
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/drpc_server.py
acd7529
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py
296b78f
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/nimbus_prod.py
108b8c1
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/rest_api.py
db921cb
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/supervisor.py
c1a0f04
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/supervisor_prod.py
0577e4b
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/ui_server.py
b7fec9b
ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/tez_client.py
9627de7
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/application_timeline_server.py
3b4d134
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py
9b8c5c0
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapreduce2_client.py
6eb04fb
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/nodemanager.py
6837c27
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py
b046c4c
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn_client.py
2518f1e
ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_client.py
193a7da
ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_server.py
abbe6b7
Diff: https://reviews.apache.org/r/46445/diff/
Testing (updated)
-------
mvn clean test -DskipSurefireTests
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ....................................... SUCCESS [8.252s]
[INFO] Apache Ambari Project POM ......................... SUCCESS [0.359s]
[INFO] Ambari Web ........................................ SUCCESS [1:24.139s]
[INFO] Ambari Views ...................................... SUCCESS [7.257s]
[INFO] Ambari Admin View ................................. SUCCESS [22.415s]
[INFO] ambari-metrics .................................... SUCCESS [0.542s]
[INFO] Ambari Metrics Common ............................. SUCCESS [1.357s]
[INFO] Ambari Metrics Hadoop Sink ........................ SUCCESS [2.101s]
[INFO] Ambari Metrics Flume Sink ......................... SUCCESS [1.261s]
[INFO] Ambari Metrics Kafka Sink ......................... SUCCESS [1.347s]
[INFO] Ambari Metrics Storm Sink ......................... SUCCESS [3.235s]
[INFO] Ambari Metrics Collector .......................... SUCCESS [29.070s]
[INFO] Ambari Metrics Monitor ............................ SUCCESS [2.343s]
[INFO] Ambari Metrics Grafana ............................ SUCCESS [19.393s]
[INFO] Ambari Metrics Assembly ........................... SUCCESS [30.671s]
[INFO] Ambari Server ..................................... SUCCESS [1:36.263s]
[INFO] Ambari Functional Tests ........................... SUCCESS [2.558s]
[INFO] Ambari Agent ...................................... SUCCESS [13.846s]
[INFO] Ambari Client ..................................... SUCCESS [0.332s]
[INFO] Ambari Python Client .............................. SUCCESS [0.906s]
[INFO] Ambari Groovy Client .............................. SUCCESS [15.671s]
[INFO] Ambari Shell ...................................... SUCCESS [0.255s]
[INFO] Ambari Python Shell ............................... SUCCESS [0.086s]
[INFO] Ambari Groovy Shell ............................... SUCCESS [11.117s]
[INFO] ambari-logsearch .................................. SUCCESS [0.802s]
[INFO] Ambari Logsearch Portal ........................... SUCCESS [4.722s]
[INFO] Ambari Logsearch Log Feeder ....................... SUCCESS [1.520s]
[INFO] Ambari Logsearch Appender ......................... SUCCESS [0.391s]
[INFO] Ambari Logsearch Assembly ......................... SUCCESS [0.185s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 6:03.806s
[INFO] Finished at: Fri Apr 22 15:48:12 PDT 2016
[INFO] Final Memory: 124M/686M
Additionally Build #6552 was successful:
https://builds.apache.org/job/Ambari-trunk-test-patch/6552/
Thanks,
Juanjo Marron