----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44210/#review130191 -----------------------------------------------------------
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py (line 44) <https://reviews.apache.org/r/44210/#comment193880> *return componentName in ('HAWQMASTER', 'HAWQSTANDBY')* ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py (line 118) <https://reviews.apache.org/r/44210/#comment193923> There is some additional logic for HAWQ mentioned in recommendHDFSConfigurations: https://github.com/apache/ambari/blob/trunk/ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py#L368-#L370 I believe this would still work from the HDP 2.3 stack advisor. Would you like to move it here? ambari-server/src/main/resources/stacks/service_advisor.py (line 48) <https://reviews.apache.org/r/44210/#comment193918> stackadvisor is being passed to many of the service advisor functions for using some utility functions like isLocalHost() These utility functions should ideally reside outside both stack advisor and service advisor. ambari-server/src/main/resources/stacks/stack_advisor.py (line 419) <https://reviews.apache.org/r/44210/#comment193899> If component A of service SA is co-located based on how component B of service SB is laid out, and services list is ['SA', 'SB'], then host assignment for A comes before B, which would be incorrect. SB's components should be recommended first, then SA's components, because A depends on host assignment of B. ambari-server/src/main/resources/stacks/stack_advisor.py (line 576) <https://reviews.apache.org/r/44210/#comment193912> createServiceAdvisor is called multiple times, in componentLayoutValidations, recommendComponentLayout, etc. Is it not possible to call it once, and cache it and use it again? ambari-server/src/main/resources/stacks/stack_advisor.py (line 654) <https://reviews.apache.org/r/44210/#comment193926> How is this different from the function defined on line 586 (right side)? - Matt On April 22, 2016, 11:27 a.m., Tim Thorpe wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44210/ > ----------------------------------------------------------- > > (Updated April 22, 2016, 11:27 a.m.) > > > Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Jayush > Luniya, Oleksandr Diachenko, Sumit Mohanty, Srimanth Gunturi, and Yusaku Sako. > > > Bugs: AMBARI-15226 > https://issues.apache.org/jira/browse/AMBARI-15226 > > > Repository: ambari > > > Description > ------- > > Currently the stack advisor is defined under each stack version such as > HDP/2.3. The problem with this is that it restricts the services that can be > added to the stack. If a custom service is to be added, they would need to > modify the stack advisor. If the configuration recommendation and validation > can be done at the service level then the custom service could just include > their own recommendations and validations separately. > > > Diffs > ----- > > ambari-server/src/main/assemblies/server.xml e1a4919 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java > df65010 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java > 00c8696 > > ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceResponse.java > ca1968e > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java > 6c6fa91 > > ambari-server/src/main/java/org/apache/ambari/server/stack/CommonServiceDirectory.java > 636de37 > > ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceDirectory.java > d574d60 > > ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java > b7e09a9 > > ambari-server/src/main/java/org/apache/ambari/server/stack/StackServiceDirectory.java > d27e52a > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java > db95fec > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py > PRE-CREATION > ambari-server/src/main/resources/properties.json eac0dbd > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py > 0130483 > ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py > 3a65541 > ambari-server/src/main/resources/stacks/service_advisor.py PRE-CREATION > ambari-server/src/main/resources/stacks/stack_advisor.py 539bd25 > ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py > 6c9fd46 > > Diff: https://reviews.apache.org/r/44210/diff/ > > > Testing > ------- > > Ran all the non java unit tests. > > Total run:945 > Total errors:0 > Total failures:0 > > Manually configured HAWQ and PXF as part of the HDP 2.3 stack and made sure > their service advisors were called. > > > Thanks, > > Tim Thorpe > >
