> On April 22, 2016, 11:19 p.m., Matt wrote:
> > ambari-server/src/main/resources/stacks/stack_advisor.py, line 434
> > <https://reviews.apache.org/r/44210/diff/2/?file=1348350#file1348350line434>
> >
> >     If component A of service SA is co-located based on how component B of 
> > service SB is laid out, and services list is ['SA', 'SB'], then host 
> > assignment for A comes before B, which would be incorrect.
> >     
> >     SB's components should be recommended first, then SA's components, 
> > because A depends on host assignment of B.

That is why I added a colocate function.  The idea here is that first all 
master components will be assigned their hosts, second all slave/client 
components will be assigned their hosts, and finally all components which need 
to be colocated will calculate their hosts.


> On April 22, 2016, 11:19 p.m., Matt wrote:
> > ambari-server/src/main/resources/stacks/service_advisor.py, line 48
> > <https://reviews.apache.org/r/44210/diff/2/?file=1348349#file1348349line48>
> >
> >     stackadvisor is being passed to many of the service advisor functions 
> > for using some utility functions like isLocalHost()
> >     
> >     These utility functions should ideally reside outside both stack 
> > advisor and service advisor.

I agree but the point of my changes here were to minimise the changes on the 
original stack advisor code.  I can look at these in a future jira.


> On April 22, 2016, 11:19 p.m., Matt wrote:
> > ambari-server/src/main/resources/stacks/stack_advisor.py, line 591
> > <https://reviews.apache.org/r/44210/diff/2/?file=1348350#file1348350line591>
> >
> >     createServiceAdvisor is called multiple times, in 
> > componentLayoutValidations, recommendComponentLayout, etc. 
> >     
> >     Is it not possible to call it once, and cache it and use it again?

It would be possible to cache like in a map by service.


> On April 22, 2016, 11:19 p.m., Matt wrote:
> > ambari-server/src/main/resources/stacks/stack_advisor.py, line 669
> > <https://reviews.apache.org/r/44210/diff/2/?file=1348350#file1348350line669>
> >
> >     How is this different from the function defined on line 586 (right 
> > side)?

Good catch, I'll go over this again and see which method has the correct 
behavior.  It could be that one of those methods should be removed or perhaps 
one should be renamed.


- Tim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44210/#review130191
-----------------------------------------------------------


On April 22, 2016, 6:27 p.m., Tim Thorpe wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44210/
> -----------------------------------------------------------
> 
> (Updated April 22, 2016, 6:27 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Jayush 
> Luniya, Oleksandr Diachenko, Sumit Mohanty, Srimanth Gunturi, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15226
>     https://issues.apache.org/jira/browse/AMBARI-15226
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Currently the stack advisor is defined under each stack version such as 
> HDP/2.3. The problem with this is that it restricts the services that can be 
> added to the stack. If a custom service is to be added, they would need to 
> modify the stack advisor. If the configuration recommendation and validation 
> can be done at the service level then the custom service could just include 
> their own recommendations and validations separately.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/assemblies/server.xml e1a4919 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
>  df65010 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java
>  00c8696 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceResponse.java
>  ca1968e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java
>  6c6fa91 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/CommonServiceDirectory.java
>  636de37 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceDirectory.java
>  d574d60 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java 
> b7e09a9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackServiceDirectory.java
>  d27e52a 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 
> db95fec 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py 
> PRE-CREATION 
>   ambari-server/src/main/resources/properties.json eac0dbd 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
> 0130483 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> 3a65541 
>   ambari-server/src/main/resources/stacks/service_advisor.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/stack_advisor.py 539bd25 
>   ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 
> 6c9fd46 
> 
> Diff: https://reviews.apache.org/r/44210/diff/
> 
> 
> Testing
> -------
> 
> Ran all the non java unit tests.  
> 
> Total run:945
> Total errors:0
> Total failures:0
> 
> Manually configured HAWQ and PXF as part of the HDP 2.3 stack and made sure 
> their service advisors were called.
> 
> 
> Thanks,
> 
> Tim Thorpe
> 
>

Reply via email to