> On April 27, 2016, 12:39 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/checks/ServiceCheckValidityCheck.java, > > lines 112-123 > > <https://reviews.apache.org/r/46729/diff/1/?file=1363148#file1363148line112> > > > > I don't think we want a "break;" here - we should probably collect all > > the SERVICE_CHECK and give them to the user.
All SERVICE_CHECKs that fail, that is - Nate ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46729/#review130804 ----------------------------------------------------------- On April 27, 2016, 5:49 a.m., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46729/ > ----------------------------------------------------------- > > (Updated April 27, 2016, 5:49 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Nate > Cole. > > > Bugs: AMBARI-16134 > https://issues.apache.org/jira/browse/AMBARI-16134 > > > Repository: ambari > > > Description > ------- > > Just checking for service checks that were run within the last hour does not > seem to be a warranty of anything. For example, user could install cluster, > run service checks once, and then enable security/LDAP/change configuration > as required by some pre-upgrade check/whatever, and still have Health Check > passing. > > So the current idea is to check configuration change history and compare > config change timestamps with last time the service check for related service > was run. > > Also log to Ambari log timestamps of latest service checks for services, and > timestamps of latest service config changes (INFO level) > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java > d701bdc > > ambari-server/src/main/java/org/apache/ambari/server/checks/HealthCheck.java > a1ab1eb > > ambari-server/src/main/java/org/apache/ambari/server/checks/ServiceCheckValidityCheck.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/checks/ServiceCheckValidityCheckTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/46729/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Dmitro Lisnichenko > >
