-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46729/
-----------------------------------------------------------
(Updated April 28, 2016, 10:36 a.m.)
Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Nate Cole.
Changes
-------
Fixed comments
Summary (updated)
-----------------
Force running service checks for services before upgrade
Bugs: AMBARI-16134
https://issues.apache.org/jira/browse/AMBARI-16134
Repository: ambari
Description
-------
Just checking for service checks that were run within the last hour does not
seem to be a warranty of anything. For example, user could install cluster, run
service checks once, and then enable security/LDAP/change configuration as
required by some pre-upgrade check/whatever, and still have Health Check
passing.
So the current idea is to check configuration change history and compare config
change timestamps with last time the service check for related service was run.
Also log to Ambari log timestamps of latest service checks for services, and
timestamps of latest service config changes (INFO level)
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java
d701bdc
ambari-server/src/main/java/org/apache/ambari/server/checks/HealthCheck.java
a1ab1eb
ambari-server/src/main/java/org/apache/ambari/server/checks/ServiceCheckValidityCheck.java
PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/checks/ServiceCheckValidityCheckTest.java
PRE-CREATION
Diff: https://reviews.apache.org/r/46729/diff/
Testing
-------
mvn clean test
Thanks,
Dmitro Lisnichenko
