----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46727/#review130815 -----------------------------------------------------------
ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/livy_server.py (line 24) <https://reviews.apache.org/r/46727/#comment194712> Prefer to use named imports ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/params.py (line 188) <https://reviews.apache.org/r/46727/#comment194713> Take a look at how other components do this now. There's a "feature" check that returns the version a certain feature is enabled. ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/params.py (line 190) <https://reviews.apache.org/r/46727/#comment194714> We shouldn't hardcode /usr/hdp, there's a variable to get the stack root. ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/params.py (line 216) <https://reviews.apache.org/r/46727/#comment194715> This variable will be undefined if len is 0. ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/setup_livy.py (line 22) <https://reviews.apache.org/r/46727/#comment194716> Should avoid import * since causes problems in customer environments. - Alejandro Fernandez On April 27, 2016, 7:43 a.m., Jeff Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46727/ > ----------------------------------------------------------- > > (Updated April 27, 2016, 7:43 a.m.) > > > Review request for Ambari and Sumit Mohanty. > > > Bugs: AMBARI-15612 > https://issues.apache.org/jira/browse/AMBARI-15612 > > > Repository: ambari > > > Description > ------- > > Add Livy to HDP 2.5 as slave component of Spark. > > Move the spark stack definiation to commoon-services and then > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/livy_server.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/livy_service.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/params.py > a64f36f > > ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/service_check.py > 694f046 > > ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/setup_livy.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/status_params.py > 19c9a0e > > ambari-server/src/main/resources/common-services/SPARK/1.6.x.2.4/configuration/spark-defaults.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/SPARK/1.6.x.2.4/configuration/spark-thrift-fairscheduler.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/SPARK/1.6.x.2.4/configuration/spark-thrift-sparkconf.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/SPARK/1.6.x.2.4/metainfo.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/SPARK/1.6.x.2.5/configuration/livy-defaults.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/SPARK/1.6.x.2.5/configuration/livy-env.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/SPARK/1.6.x.2.5/configuration/livy-log4j-properties.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/SPARK/1.6.x.2.5/kerberos.json > PRE-CREATION > > ambari-server/src/main/resources/common-services/SPARK/1.6.x.2.5/metainfo.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.4/services/SPARK/configuration/spark-defaults.xml > 1a6552f > > ambari-server/src/main/resources/stacks/HDP/2.4/services/SPARK/configuration/spark-thrift-fairscheduler.xml > 2dda4bb > > ambari-server/src/main/resources/stacks/HDP/2.4/services/SPARK/configuration/spark-thrift-sparkconf.xml > 4f2563b > ambari-server/src/main/resources/stacks/HDP/2.4/services/SPARK/metainfo.xml > a5a19f6 > ambari-server/src/main/resources/stacks/HDP/2.5/role_command_order.json > f7e15aa > ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/metainfo.xml > 107ca93 > > Diff: https://reviews.apache.org/r/46727/diff/ > > > Testing > ------- > > Manully verify it. Livy is installed correctly in non-secure and secure > cluster. > > > Thanks, > > Jeff Zhang > >
