> On April 28, 2016, 4:21 a.m., Sumit Mohanty wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProvider.java, > > line 209 > > <https://reviews.apache.org/r/46751/diff/1/?file=1364000#file1364000line209> > > > > should the change be conditional - for FS that can provide high > > throughput we have not had the need for these changes. IOW, what are the > > downside of these changes?
Not really necessary since this used to be the behavior prior to 2.1.2 / cache introduction. We want to fail fast to avoid compounding the timeouts by making multiple AMS calls for a single Ambari request. > On April 28, 2016, 4:21 a.m., Sumit Mohanty wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/cache/TimelineMetricCache.java, > > line 70 > > <https://reviews.apache.org/r/46751/diff/1/?file=1364003#file1364003line70> > > > > How long before timeout is hit? Timeouts are configurable. Cache miss = 10 seconds, Cache update = 10 (default) The update can be tuned to a lower value for a slow performing metrics system. > On April 28, 2016, 4:21 a.m., Sumit Mohanty wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/cache/TimelineMetricCacheEntryFactory.java, > > line 92 > > <https://reviews.apache.org/r/46751/diff/1/?file=1364004#file1364004line92> > > > > Typically how long is the delay after which it will throw the exception. 10 seconds. - Sid ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46751/#review130880 ----------------------------------------------------------- On April 27, 2016, 9:47 p.m., Sid Wagle wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46751/ > ----------------------------------------------------------- > > (Updated April 27, 2016, 9:47 p.m.) > > > Review request for Ambari, Aravindan Vijayan, Dmytro Sen, Jonathan Hurley, > and Sumit Mohanty. > > > Bugs: AMBARI-16143 > https://issues.apache.org/jira/browse/AMBARI-16143 > > > Repository: ambari > > > Description > ------- > > In case of a SocketTimeoutException skip populating the resource with metrics > until the next retry. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProvider.java > 939ee7f > > ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSReportPropertyProvider.java > 8b60c50 > > ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/MetricsRequestHelper.java > ca20e54 > > ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/cache/TimelineMetricCache.java > 9e343e3 > > ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/cache/TimelineMetricCacheEntryFactory.java > e8a2aef > > ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProviderTest.java > ce865cf > > Diff: https://reviews.apache.org/r/46751/diff/ > > > Testing > ------- > > Added a unit test. Manually verified the patch works on a cluster. > > > Thanks, > > Sid Wagle > >
