> On May 14, 2016, 12:19 a.m., Sumit Mohanty wrote: > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py, > > line 240 > > <https://reviews.apache.org/r/47377/diff/1/?file=1383307#file1383307line240> > > > > We should add an explicit unit test that tests this path with multiple > > output lines. Modifying test_start_default in test_hive_server_int to > > return multiple lines in mock may just do it.
Added. - Swapan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47377/#review133234 ----------------------------------------------------------- On May 14, 2016, 12:13 a.m., Swapan Shridhar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47377/ > ----------------------------------------------------------- > > (Updated May 14, 2016, 12:13 a.m.) > > > Review request for Ambari, Jaimin Jetly and Sumit Mohanty. > > > Repository: ambari > > > Description > ------- > > LLAP start/restart, after creating LLAP package relies on output that is > being generated in order to figure out the package name created. Typically > looks for line : > > ---------- > Prepared llap-slider<date....>/run.sh for running LLAP on Slider > ---------- > ---------- > > However, it doesn't handle parsing multi-line outputs (example): > > ---------- > # #### #### ##### ### #### > ### #### ###### #### #### #### ##### ### ## ### #### > Prepared llap-slider2016-05-13_23-13-07/run.sh for running LLAP on Slider > ---------- > ---------- > > **Resolution** : Fixed the code for parsing lines while looking for output > line. > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py > e94b22e > > Diff: https://reviews.apache.org/r/47377/diff/ > > > Testing > ------- > > Yes. > > Pythn UT passes. > > > Thanks, > > Swapan Shridhar > >