> On Травень 19, 2016, 2:05 після полудня, Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/api/predicate/QueryParser.java, > > lines 103-105 > > <https://reviews.apache.org/r/47531/diff/1/?file=1386614#file1386614line103> > > > > What about any endpoint that takes host names embedded in json? Is that > > covered here? > > > > A fundamental change like this requires several unit tests covering > > QueryParser and predicate processors. Also add tests for the Request > > endpoint that take hostnames in the body (as opposed to the URL).
Nate. this code was added only for SmartSense needs. If you will take a look at description you will see that i was asked to add "hostname lowercase" for API requests. For API requests which contain hostname and API which has filter with hostname. - Vitalyi ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47531/#review133940 ----------------------------------------------------------- On Травень 20, 2016, 3:27 після полудня, Vitalyi Brodetskyi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47531/ > ----------------------------------------------------------- > > (Updated Травень 20, 2016, 3:27 після полудня) > > > Review request for Ambari, Dmytro Sen, Nate Cole, Sumit Mohanty, and Sid > Wagle. > > > Repository: ambari > > > Description > ------- > > Ambari stores all hostnames in lower-case irrespective of the case in name > associated with the host. While this is OK for internal usage it causes > confusion to the users or the tools that look up hostname using standard > commands such as"hostname -f". > The API should be modified to allow hostnames in case insensitive fashion. > E.g. > api/v1/hosts/HostA and api/v1/hosts/hosta both should point to the same host > calls that user filter where they specify hostnames should also allow case > insensitive comparison > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/api/predicate/QueryParser.java > 3af90ba > > ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java > 9c864b6 > > ambari-server/src/test/java/org/apache/ambari/server/api/predicate/QueryParserTest.java > 90ad522 > > ambari-server/src/test/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImplTest.java > dfe8be7 > > Diff: https://reviews.apache.org/r/47531/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Vitalyi Brodetskyi > >
