----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47621/ -----------------------------------------------------------
(Updated May 20, 2016, 6:23 p.m.) Review request for Ambari, Alejandro Fernandez and Sumit Mohanty. Changes ------- Updated review with Test cases and debug statements. Bugs: AMBARI-16784 https://issues.apache.org/jira/browse/AMBARI-16784 Repository: ambari Description ------- - As hive2/hive-site.xml only contains the new + the changed props compared to hive/hive-site.xml, we merge hive/hive-site.xml and hive2/hive-site.xml and store it in hive2/hive-site.xml. - Thus, as part of the merge, specifically for Hive2/hive-site.xml config 'hive.exec.post.hooks', it gets the hook for Atlas from Hive1/hive-site.xml, if Atlas is installed. As Atlas is not supported by Hive2, we need to remove it. Diffs (updated) ----- ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py 8e49cf0 ambari-server/src/test/python/stacks/2.5/HIVE/test_hive_server_int.py ee93f9e ambari-server/src/test/python/stacks/2.5/configs/hsi_default.json 65ff8b3 Diff: https://reviews.apache.org/r/47621/diff/ Testing (updated) ------- - Tested removal of 'org.apache.atlas.hive.hook.HiveHook' value from 'hive.exec.post.hooks'. - - Added Unit Test. - Python UT passes. Thanks, Swapan Shridhar