----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47766/#review134724 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java (lines 2236 - 2237) <https://reviews.apache.org/r/47766/#comment199616> a better naming or some comment could be useful to know what "m" and "sh"are - Daniel Gergely On máj. 24, 2016, 1:29 du, Balázs Bence Sári wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47766/ > ----------------------------------------------------------- > > (Updated máj. 24, 2016, 1:29 du) > > > Review request for Ambari, Daniel Gergely, Laszlo Puskas, Oliver Szabo, > Sandor Magyari, and Sebastian Toader. > > > Bugs: AMBARI-16822 > https://issues.apache.org/jira/browse/AMBARI-16822 > > > Repository: ambari > > > Description > ------- > > Host name resolution for dfs_ha_initial_namenode_active and > dfs_ha_initial_namenode_standby properties. Support for these two properties > has been added added to BluePrintProcessor. Also made sure the these > properties are not exported with blueprints as per the docs. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java > 1ddc4e1 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java > 5c6aeaf > > Diff: https://reviews.apache.org/r/47766/diff/ > > > Testing > ------- > > - Wrote a unit test to check host name resolution for the two properties. > - Wrote a unit test to check that the two properties are not exported with > blueprints. > - All unit tests in ambari-server passed. > - Run a manual test to verify that the host names are resolved for the two > properties and the two properties are not exported with blueprints. > > > Thanks, > > Balázs Bence Sári > >
