-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48121/#review135962
-----------------------------------------------------------


Fix it, then Ship it!




The patch looks fine to me, just a minor question below that should probably be 
verified prior to checkin.

Thanks.


ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
 (line 337)
<https://reviews.apache.org/r/48121/#comment200975>

    This code looks fine to me, but are we sure that there are no properties in 
an HDP cluster that may consider trailing spaces to be a valid property value? 
    
    It's probably fine, but just wanted to make sure we double-check this. 
    
    Thanks.


- Robert Nettleton


On June 2, 2016, 4:38 p.m., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48121/
> -----------------------------------------------------------
> 
> (Updated June 2, 2016, 4:38 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Robert Nettleton, Sebastian 
> Toader, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-16979
>     https://issues.apache.org/jira/browse/AMBARI-16979
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The default value of yarn.resourcemanager.zk-acl is set to 
> "world:anyone:rwcda ". The extra space is causing the yarn config to be 
> considered invalid
> The default value of scheduler shows empty.
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  a0af813 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/configuration/yarn-site.xml
>  905383a 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3.GlusterFS/services/YARN/configuration/yarn-site.xml
>  d562246 
>   
> ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/YARN/configuration/yarn-site.xml
>  a3cf59a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
>  ec04fd2 
> 
> Diff: https://reviews.apache.org/r/48121/diff/
> 
> 
> Testing
> -------
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Reply via email to