> On Июнь 2, 2016, 4:55 п.п., Robert Nettleton wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java,
> >  line 337
> > <https://reviews.apache.org/r/48121/diff/2/?file=1403128#file1403128line337>
> >
> >     This code looks fine to me, but are we sure that there are no 
> > properties in an HDP cluster that may consider trailing spaces to be a 
> > valid property value? 
> >     
> >     It's probably fine, but just wanted to make sure we double-check this. 
> >     
> >     Thanks.

Not all the properies should be trimmed. I'll implement trimming in a separate 
jira.


- Dmytro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48121/#review135962
-----------------------------------------------------------


On Июнь 3, 2016, 10:43 д.п., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48121/
> -----------------------------------------------------------
> 
> (Updated Июнь 3, 2016, 10:43 д.п.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Robert Nettleton, Sebastian 
> Toader, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-16979
>     https://issues.apache.org/jira/browse/AMBARI-16979
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The default value of yarn.resourcemanager.zk-acl is set to 
> "world:anyone:rwcda ". The extra space is causing the yarn config to be 
> considered invalid
> The default value of scheduler shows empty.
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/configuration/yarn-site.xml
>  858f375 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3.GlusterFS/services/YARN/configuration/yarn-site.xml
>  9777ee4 
>   
> ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/YARN/configuration/yarn-site.xml
>  c8a588c 
> 
> Diff: https://reviews.apache.org/r/48121/diff/
> 
> 
> Testing
> -------
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Reply via email to