> On May 25, 2016, 8:29 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/setup_spark.py, > > line 25 > > <https://reviews.apache.org/r/47579/diff/2/?file=1391172#file1391172line25> > > > > Use explicit import > > Jayush Luniya wrote: > Sorry I missed these. Saisai, can you include these changes with > AMBARI-16864
@Saisai can you close this review? - Jayush ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47579/#review134827 ----------------------------------------------------------- On May 23, 2016, 2:55 a.m., Saisai Shao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47579/ > ----------------------------------------------------------- > > (Updated May 23, 2016, 2:55 a.m.) > > > Review request for Ambari, Jayush Luniya and Sumit Mohanty. > > > Bugs: AMBARI-16753 > https://issues.apache.org/jira/browse/AMBARI-16753 > > > Repository: ambari > > > Description > ------- > > Add Spark2 service definition for Ambari > > > Diffs > ----- > > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/alerts.json > PRE-CREATION > > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-defaults.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-env.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-hive-site-override.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-log4j-properties.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-metrics-properties.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-thrift-fairscheduler.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-thrift-sparkconf.xml > PRE-CREATION > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/kerberos.json > PRE-CREATION > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/metainfo.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/job_history_server.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/params.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/service_check.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/setup_spark.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/spark_client.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/spark_service.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/spark_thrift_server.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/status_params.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/quicklinks/quicklinks.json > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK2/metainfo.xml > PRE-CREATION > > Diff: https://reviews.apache.org/r/47579/diff/ > > > Testing > ------- > > Local manual test > > > Thanks, > > Saisai Shao > >