> On June 2, 2016, 4:23 p.m., Alejandro Fernandez wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/hdp_select.py,
> >  line 129
> > <https://reviews.apache.org/r/48044/diff/1/?file=1400993#file1400993line129>
> >
> >     This cannot assume the directory will be /usr/hdp, instead use 
> > stack_root variable.

Looks like different patches are needed for branch-2.4 and branch-2.2. Starting 
2.4 {stack_root}/{version_to_select} can be used and for the older version it 
can be /usr/hdp.


- Sumit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48044/#review135943
-----------------------------------------------------------


On June 2, 2016, 12:55 p.m., Laszlo Puskas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48044/
> -----------------------------------------------------------
> 
> (Updated June 2, 2016, 12:55 p.m.)
> 
> 
> Review request for Ambari, Oliver Szabo, Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-16952
>     https://issues.apache.org/jira/browse/AMBARI-16952
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> In case the hdp-select command fails during a service / component 
> installation there's no contextual information about the cause of the failure.
> This issue is for logging information about the machine on which the 
> hdp-select command fails.
> This solution wraps hdp-select command calls in a try/catch block and logs 
> failure / hdp installationrelated information.
> 
> 
> Diffs
> -----
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/hdp_select.py
>  9a3201e 
> 
> Diff: https://reviews.apache.org/r/48044/diff/
> 
> 
> Testing
> -------
> 
> Manual testing underway.
> 
> 
> Thanks,
> 
> Laszlo Puskas
> 
>

Reply via email to