----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48044/#review136336 -----------------------------------------------------------
Fix it, then Ship it! ambari-common/src/main/python/resource_management/libraries/functions/hdp_select.py (line 136) <https://reviews.apache.org/r/48044/#comment201354> Please add a comment as to why this was done. - Alejandro Fernandez On June 6, 2016, 3:15 p.m., Laszlo Puskas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48044/ > ----------------------------------------------------------- > > (Updated June 6, 2016, 3:15 p.m.) > > > Review request for Ambari, Andrew Onischuk, Oliver Szabo, Sumit Mohanty, and > Sebastian Toader. > > > Bugs: AMBARI-16952 > https://issues.apache.org/jira/browse/AMBARI-16952 > > > Repository: ambari > > > Description > ------- > > In case the hdp-select command fails during a service / component > installation there's no contextual information about the cause of the failure. > This issue is for logging information about the machine on which the > hdp-select command fails. > This solution wraps hdp-select command calls in a try/catch block and logs > failure / hdp installationrelated information. > > > Diffs > ----- > > > ambari-common/src/main/python/resource_management/libraries/functions/hdp_select.py > 9a3201e > > Diff: https://reviews.apache.org/r/48044/diff/ > > > Testing > ------- > > Unit tests passed. > Manual testing underway please don't commit yet. > // found some major differences between the branches / investigating it > > > Thanks, > > Laszlo Puskas > >
