> On June 6, 2016, 6:04 p.m., Jonathan Hurley wrote: > > ambari-common/src/main/python/resource_management/libraries/script/script.py, > > lines 664-666 > > <https://reviews.apache.org/r/48287/diff/1/?file=1407038#file1407038line664> > > > > I know this isn't a part of your change - but can this TODO be removed > > now? I'm hoping that Ranger has service checks in place. And this would > > alter your if-statement if removed.
i can remove TODO but not the logic, seems even simple restart in normal cluster mode will fail without this. I have seen open issue in ranger team for fixing this part. - Dmytro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48287/#review136331 ----------------------------------------------------------- On June 6, 2016, 5:20 p.m., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48287/ > ----------------------------------------------------------- > > (Updated June 6, 2016, 5:20 p.m.) > > > Review request for Ambari, Jonathan Hurley and Nate Cole. > > > Bugs: AMBARI-17068 > https://issues.apache.org/jira/browse/AMBARI-17068 > > > Repository: ambari > > > Description > ------- > > STR: > - deploy latest Ambari 2.4 > - install HDP 2.3 (HIVE and dependencies) > - update to HDP 2.5 > > > Error message: > > {code} > Traceback (most recent call last): > File > "/var/lib/ambari-agent/cache/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py", > line 211, in <module> > HiveServer().execute() > File > "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py", > line 257, in execute > method(env) > File > "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py", > line 669, in restart > raise Fail("Stop command finished but process keep running.") > resource_management.core.exceptions.Fail: Stop command finished but process > keep running. > {code} > > > Diffs > ----- > > ambari-agent/src/test/python/resource_management/TestScript.py adb8501 > > ambari-common/src/main/python/resource_management/libraries/script/script.py > 61759cc > > Diff: https://reviews.apache.org/r/48287/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Dmitro Lisnichenko > >
