----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48624/#review137351 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java (line 2439) <https://reviews.apache.org/r/48624/#comment202504> Move these properties out of the for-loop. If they are empty, should be be an error instead of a "continue" - Alejandro Fernandez On June 13, 2016, 9:41 a.m., Gaurav Nagar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48624/ > ----------------------------------------------------------- > > (Updated June 13, 2016, 9:41 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-17188 > https://issues.apache.org/jira/browse/AMBARI-17188 > > > Repository: ambari > > > Description > ------- > > Upgrade cluster_handle column to have current cluster_id if it is not null. > Check null or empty configuration properties for custom capacity scheduler > view. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java > 7451bbe > > Diff: https://reviews.apache.org/r/48624/diff/ > > > Testing > ------- > > Manually Tested > > > Thanks, > > Gaurav Nagar > >