-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48814/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, and Sumit Mohanty.
Bugs: AMBARI-17283
https://issues.apache.org/jira/browse/AMBARI-17283
Repository: ambari
Description
-------
Following changes have bee done:
4 configs that are of interest to us, which need to show up as LABEL in Hive
Server interactive panel :
- hive-interactive-site/hive.llap.daemon.yarn.container.mb
- hive-interactive-site/hive.llap.daemon.num.executors
- hive-interactive-site/hive.llap.io.memory.size
- hive-interactive-env/num_llap_nodes
Made copies of these configs as follows, to be used as LABELs:
- hive-interactive-site/hive.llap.daemon.yarn.container.mb**_copy**
- hive-interactive-site/hive.llap.daemon.num.executors**_copy**
- hive-interactive-site/hive.llap.io.memory.size**_copy**
- hive-interactive-env/num_llap_nodes**_copy**
2.5/HIVE/theme.json has been modified to use '*_copy' configs for display on
HIVE SERVER INTERACTIVE panel.
- Thus, existing 4 configs will now be seen editable in HIVE Advanced
section.
At any point, wherever, existing configs value will change for eg:
'hive.llap.io.memory.size' (and same applies for others),
the corresponding value for config '*_copy' will be updated, with SA code
supporting that update to be take place.
**Example:**
{code}
<property>
<name>hive.llap.io.memory.size_copy</name>
<!--
Added for displaying 'hive.llap.io.memory.size' value as a 'label' on
Hive Server Interactive panel and will always
have same value as 'hive.llap.io.memory.size'. 'hive.llap.io.memory.size'
will stay editable in Advanced section.
-->
<display-name>In-Memory Cache per Daemon</display-name>
<description>The amount of memory reserved for Hive's optimized in-memory
cache.</description>
<value>0</value>
<value-attributes>
<type>int</type>
<unit>MB</unit>
<overridable>false</overridable>
</value-attributes>
<depends-on>
<property>
<type>hive-interactive-env</type>
<name>enable_hive_interactive</name>
</property>
<property>
<type>hive-interactive-site</type>
<name>hive.llap.io.memory.size</name>
</property>
</depends-on>
<on-ambari-upgrade add="true"/>
</property>
{code}
Thus, both set of configs will stay in parity at all times.
Diffs
-----
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-env.xml
4d34455
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml
1b2eaf5
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/themes/theme.json
395ae43
ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py
b896a6a
ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 7d5a03f
Diff: https://reviews.apache.org/r/48814/diff/
Testing
-------
- Python UT tests added.
Thanks,
Swapan Shridhar
