> On June 16, 2016, 2:56 p.m., Robert Nettleton wrote: > > I believe this patch might have some issues that need clarification prior > > to merging this. > > > > The review and bug don't specify why this change is necessary, so I'm a > > little confused as to why this change is required in general. > > > > I think someone from the Metrics team should review this, with respect to > > the "0.0.0.0" address, since this is a special address that may require > > more custom handling in the BlueprintConfigurationProcessor. > > > > Thanks.
Since Aravindan from the Metrics team has approved this patch, I'll remove my issues, since they were mainly connected to how this would work with Metrics. - Robert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48729/#review137985 ----------------------------------------------------------- On June 15, 2016, 1:35 p.m., Dmytro Sen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48729/ > ----------------------------------------------------------- > > (Updated June 15, 2016, 1:35 p.m.) > > > Review request for Ambari, Aravindan Vijayan, Sumit Mohanty, and Sid Wagle. > > > Bugs: AMBARI-17255 > https://issues.apache.org/jira/browse/AMBARI-17255 > > > Repository: ambari > > > Description > ------- > > After updating the property timeline.metrics.service.webapp.address to > 0.0.0.0:6188 (earlier it was localhost:6188), I am able to access metadata > using the command curl http://host1:6188/ws/v1/timeline/metrics/metadata > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java > 9094698 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/alerts/alert_metrics_deviation.py > 9ff1273 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java > cda8fb8 > > ambari-server/src/test/python/stacks/2.0.6/HDFS/test_alert_metrics_deviation.py > b7d96b7 > > Diff: https://reviews.apache.org/r/48729/diff/ > > > Testing > ------- > > Unit tests passed > > > Thanks, > > Dmytro Sen > >
