-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49786/
-----------------------------------------------------------

Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.


Bugs: AMBARI-17615
    https://issues.apache.org/jira/browse/AMBARI-17615


Repository: ambari


Description
-------

AMS API which used to work in previous versions is now broken in 2.4.0 version

GET 

http://<host>:6188/ws/v1/timeline/metrics?metricNames=bytes_in._min,bytes_in._max,bytes_in._sum,bytes_in._avg&appId=HOST&precision=hours&startTime=1466928000000&endTime=1467439200000&hostname=<host>

failed. Status:400
{
"exception": "BadRequestException",
"message": "java.lang.Exception: Multiple aggregate functions not supported.",
"javaClassName": "org.apache.hadoop.yarn.webapp.BadRequestException"
}

This impacts SmartSense capture

FIX

Changed data structure that stores the MetricName -> Aggregation Function from 
HashMap to Multimap, so that we can have 1 metric name mapping to separate 
lists of functions.


Diffs
-----

  ambari-metrics/ambari-metrics-timelineservice/pom.xml a0e4adf 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java
 9510574 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java
 bbd6d83 
  
ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStoreTest.java
 29e2664 
  
ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/ITPhoenixHBaseAccessor.java
 ae1aa5a 
  
ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessorTest.java
 a86fa11 

Diff: https://reviews.apache.org/r/49786/diff/


Testing
-------

mvn clean test


Thanks,

Aravindan Vijayan

Reply via email to