-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49786/#review141633
-----------------------------------------------------------


Fix it, then Ship it!





ambari-metrics/ambari-metrics-timelineservice/pom.xml (line 537)
<https://reviews.apache.org/r/49786/#comment206969>

    why not 1.0?



ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java
 (line 290)
<https://reviews.apache.org/r/49786/#comment206970>

    Why is this function static in a non-helper class ?



ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStoreTest.java
 (line 37)
<https://reviews.apache.org/r/49786/#comment206971>

    Please change to explicit imports.



ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStoreTest.java
 (line 59)
<https://reviews.apache.org/r/49786/#comment206972>

    No unit testing of same metric multiple functions ?


- Sid Wagle


On July 8, 2016, 6:26 a.m., Aravindan Vijayan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49786/
> -----------------------------------------------------------
> 
> (Updated July 8, 2016, 6:26 a.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-17615
>     https://issues.apache.org/jira/browse/AMBARI-17615
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> AMS API which used to work in previous versions is now broken in 2.4.0 version
> 
> GET 
> 
> http://<host>:6188/ws/v1/timeline/metrics?metricNames=bytes_in._min,bytes_in._max,bytes_in._sum,bytes_in._avg&appId=HOST&precision=hours&startTime=1466928000000&endTime=1467439200000&hostname=<host>
> 
> failed. Status:400
> {
> "exception": "BadRequestException",
> "message": "java.lang.Exception: Multiple aggregate functions not supported.",
> "javaClassName": "org.apache.hadoop.yarn.webapp.BadRequestException"
> }
> 
> This impacts SmartSense capture
> 
> FIX
> 
> Changed data structure that stores the MetricName -> Aggregation Function 
> from HashMap to Multimap, so that we can have 1 metric name mapping to 
> separate lists of functions.
> 
> 
> Diffs
> -----
> 
>   ambari-metrics/ambari-metrics-timelineservice/pom.xml a0e4adf 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java
>  9510574 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java
>  bbd6d83 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStoreTest.java
>  29e2664 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/ITPhoenixHBaseAccessor.java
>  ae1aa5a 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessorTest.java
>  a86fa11 
> 
> Diff: https://reviews.apache.org/r/49786/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> Apache
> 
> +1 overall. Here are the results of testing the latest attachment 
> http://issues.apache.org/jira/secure/attachment/12816764/AMBARI-17615.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> +1 tests included. The patch appears to include 3 new or modified test files.
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> +1 core tests. The patch passed unit tests in 
> ambari-metrics/ambari-metrics-timelineservice.
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/7732//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/7732//console
> This message is automatically generated.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Reply via email to