-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49783/#review141274
-----------------------------------------------------------


Ship it!




Ship It!

- Robert Levas


On July 7, 2016, 10:59 p.m., Alejandro Fernandez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49783/
> -----------------------------------------------------------
> 
> (Updated July 7, 2016, 10:59 p.m.)
> 
> 
> Review request for Ambari, Madhan Neethiraj, Sumit Mohanty, and Suma 
> Shivaprasad.
> 
> 
> Bugs: AMBARI-17616
>     https://issues.apache.org/jira/browse/AMBARI-17616
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> This Jira contains several fixes.
> 1. Separate Atlas versions 0.1.0 (HDP 2.3 and 2.4), and 0.7.0 (HDP 2.5) for 
> Atlas.
> This way, all of the LDAP/AD changes only affect HDP 2.5.
> This means that HDP 2.5 will have the smart configs theme.
> 
> 2. Allow atlas.authentication.method.ldap.type to contain the value "none"
> If the value is none, then do not require any of the LDAP or AD configs.
> Stack advisor must support this change.
> 
> 
> 3. For the LDAP and AD configs that are required, do not allow an empty 
> value. Only these 4 LDAP/AD properties can be optional:
> atlas.authentication.method.ldap.referral
> atlas.authentication.method.ldap.default.role
> atlas.authentication.method.ldap.ad.referral
> atlas.authentication.method.ldap.ad.default.role
> 
> 
> 4. Set all of the configs in atlas-application.properties to have,
> 
> ```
> <on-ambari-upgrade add="false"/>
> ```
> 
> 
> 5. When generating the file atlas-application.properties.xml for Hive, 
> Falcon, Storm, and Sqoop, only copy a subset of the configs from Atlas' 
> application.properties, these configs are
> 
> ```
>   "atlas.kafka.zookeeper.connect",
>   "atlas.kafka.bootstrap.servers",
>   "atlas.kafka.zookeeper.session.timeout.ms",
>   "atlas.kafka.zookeeper.connection.timeout.ms",
>   "atlas.kafka.zookeeper.sync.time.ms",
>   "atlas.kafka.hook.group.id",
>   "atlas.notification.create.topics",
>   "atlas.notification.replicas",
>   "atlas.notification.topics",
>   "atlas.notification.kafka.service.principal",
>   "atlas.notification.kafka.keytab.location",
>   "atlas.jaas.KafkaClient.loginModuleName",
>   "atlas.jaas.KafkaClient.loginModuleControlFlag",
>   "atlas.jaas.KafkaClient.option.useKeyTab",
>   "atlas.jaas.KafkaClient.option.storeKey",
>   "atlas.jaas.KafkaClient.option.serviceName",
>   "atlas.jaas.KafkaClient.option.keyTab",
>   "atlas.jaas.KafkaClient.option.principal",
>   "atlas.cluster.name"
> ```
> 
> 
> Diffs
> -----
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/setup_atlas_hook.py
>  872147a 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/application-properties.xml
>  b1b945d 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/metainfo.xml 
> b2fc143 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/themes/theme.json
>  414633e 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/configuration/application-properties.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/kerberos.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/metainfo.xml 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/quicklinks/quicklinks.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/themes/theme.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/configuration/application-properties.xml
>  57b31a7 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/kerberos.json 
> fd05edf 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/metainfo.xml 
> 020e339 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/quicklinks/quicklinks.json
>  ce266c4 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 1d092cd 
> 
> Diff: https://reviews.apache.org/r/49783/diff/
> 
> 
> Testing
> -------
> 
> Verified that could install Atlas on a cluster.
> Python unit tests passed.
> ----------------------------------------------------------------------
> Total run:1015
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Reply via email to