> On July 11, 2016, 9:51 p.m., Masahiro Tanaka wrote: > > Should I UpgradeCatalog250.java as we are readying to release Ambari2.4.0? > > Jonathan Hurley wrote: > That depends; there's no Fix Version on this Jira, so I don't know if > it's only going into trunk or if it's going to into branch-2.4. If you get > approval to put this in branch 2.4 from the 2.4 release manager, then you can > add it to UgpradeCatalog240. If this is going only in trunk, then you'll want > to create it a new UpgradeCatalog250. > > Masahiro Tanaka wrote: > Thanks. I'll ask release manager if this patch should be into branch-2.4 > or not.
@Masahiro, since this JIRA is not Critical/Blocker for 2.4.0, we should consider the fix for 2.5.0. Can you update the patch accordingly? - Jayush ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48972/#review141786 ----------------------------------------------------------- On July 11, 2016, 9:50 p.m., Masahiro Tanaka wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48972/ > ----------------------------------------------------------- > > (Updated July 11, 2016, 9:50 p.m.) > > > Review request for Ambari, Florian Barca, Jonathan Hurley, and Nate Cole. > > > Bugs: AMBARI-17253 > https://issues.apache.org/jira/browse/AMBARI-17253 > > > Repository: ambari > > > Description > ------- > > There are too many WARNING in ZooKeeper log. > ``` > 2016-06-15 21:02:15,405 - WARN > [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181:NIOServerCnxn@357] - caught end of > stream exception > EndOfStreamException: Unable to read additional data from client sessionid > 0x0, likely client has closed socket > at > org.apache.zookeeper.server.NIOServerCnxn.doIO(NIOServerCnxn.java:228) > at > org.apache.zookeeper.server.NIOServerCnxnFactory.run(NIOServerCnxnFactory.java:208) > at java.lang.Thread.run(Thread.java:745) > ``` > > It may be because of Ambari Alert. Ambari Alert pings to the zookeeper port > to do monitoring. > We should use 'ruok' to monitor zookeepers. > > > Diffs > ----- > > ambari-agent/src/main/python/ambari_agent/alerts/port_alert.py 1918327 > ambari-agent/src/test/python/ambari_agent/TestPortAlert.py dffa56c > > ambari-server/src/main/java/org/apache/ambari/server/state/alert/PortSource.java > d7279de > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java > 7ef12a7 > > ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/alerts.json > 469036a > > Diff: https://reviews.apache.org/r/48972/diff/ > > > Testing > ------- > > mvn clean test > > ``` > +1 overall. Here are the results of testing the latest attachment > http://issues.apache.org/jira/secure/attachment/12811835/AMBARI-17253.2.patch > against trunk revision . > +1 @author. The patch does not contain any @author tags. > +1 tests included. The patch appears to include 1 new or modified test files. > +1 javac. The applied patch does not increase the total number of javac > compiler warnings. > +1 release audit. The applied patch does not increase the total number of > release audit warnings. > +1 core tests. The patch passed unit tests in . > Test results: > https://builds.apache.org/job/Ambari-trunk-test-patch/7427//testReport/ > Console output: > https://builds.apache.org/job/Ambari-trunk-test-patch/7427//console > This message is automatically generated. > ``` > > > Thanks, > > Masahiro Tanaka > >