> On July 18, 2016, 10:58 a.m., Robert Levas wrote: > > ambari-server/src/main/resources/common-services/KAFKA/0.9.0/kerberos.json, > > line 18 > > <https://reviews.apache.org/r/50047/diff/1/?file=1444192#file1444192line18> > > > > This is redundant... > > > > `kafka-broker/listeners` = `kafka-broker/listeners` > > Anita Jebaraj wrote: > Hi Robert, I had to include the declaration for listeners in > kerberos.json since the value for listeners wont be displayed in the UI under > the kerberos configuration otherwise. There is a change in value for protocol > for listeners in specific cases (if the user hasn't added a listener with > PLAINTEXTSASL protocol) and I thought it would be appropriate to include it > in kerberos.json, even though the handling is done in the stack-advisor.py > > Robert Levas wrote: > In this case, maybe it is better to do > > ``` > "listeners": "" > ``` > > Else you may wind up with `kafka-broker/listeners` being set to > `${kafka-broker/listeners}` (literally). > > Anita Jebaraj wrote: > I am not sure if assigning an empty value for listeners in kerberos.json > is the right approach, I am thinking if using functions similar to each() in > templeton.hive.properties in VariableReplacementHelper.java would work out > for this scenario. May be creating a function replace() for listeners will > help, it can be {kafka-broker/listeners|replace()}. Please give me your > suggestion on this. > > Robert Levas wrote: > I think `replace()` will be ok. Then it will be something like: > > ``` > "listeners": "${kafka-broker/listeners|replace(PLAINTEXT, PLAINTEXTSASL)}" > ```
Hi Robert, I have updated the patch based on your comments - Anita ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50047/#review142546 ----------------------------------------------------------- On July 20, 2016, 10:01 p.m., Anita Jebaraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50047/ > ----------------------------------------------------------- > > (Updated July 20, 2016, 10:01 p.m.) > > > Review request for Ambari, Di Li and Robert Levas. > > > Bugs: AMBARI-17694 > https://issues.apache.org/jira/browse/AMBARI-17694 > > > Repository: ambari > > > Description > ------- > > When kerberos is enabled, the protocol for listeners in > /etc/kafka/conf/server.properties is updated from PLAINTEXT to PLAINTEXTSASL, > even though the Ambari UI shows otherwise > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/VariableReplacementHelper.java > 66be3bf > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/kafka.py > ac7b0ae > ambari-server/src/main/resources/common-services/KAFKA/0.9.0/kerberos.json > 2b1c01b > > ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/VariableReplacementHelperTest.java > ee2a671 > > Diff: https://reviews.apache.org/r/50047/diff/ > > > Testing > ------- > > Added 1 new test case, > Ran mvn test > > > Thanks, > > Anita Jebaraj > >
