> On July 29, 2016, 10:26 a.m., Dmytro Grinenko wrote: > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/HiveLog4jMetricsAction.java, > > line 73 > > <https://reviews.apache.org/r/50532/diff/3/?file=1456907#file1456907line73> > > > > please use regexp, as > > log4j.logger.com.github.joshelser.dropwizard.metrics.hadoop property can > > be already defined with different set of values or can be present without > > an coment. > > > > > > for an example > > "^\s*log4j.logger.com.github.joshelser.dropwizard.metrics.hadoop\s*=\s*(.*)$"
^\s*log4j\.logger\.com\.github\.joshelser\.dropwizard\.metrics\.hadoop\s*=\s*(.*)$ , that nice code formatting on rb - Dmytro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50532/#review144072 ----------------------------------------------------------- On July 28, 2016, 11:07 p.m., Aravindan Vijayan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50532/ > ----------------------------------------------------------- > > (Updated July 28, 2016, 11:07 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Jonathan > Hurley, Nate Cole, Sumit Mohanty, and Sid Wagle. > > > Bugs: AMBARI-17949 > https://issues.apache.org/jira/browse/AMBARI-17949 > > > Repository: ambari > > > Description > ------- > > In hive-log4j content, the following needs to be added during HDP upgrades to > 2.5. > > # Silence HadoopMetrics2Reporter INFO logs > log4j.logger.com.github.joshelser.dropwizard.metrics.hadoop=WARN,DRFA > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/HiveLog4jMetricsAction.java > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml > 7197e29 > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml > 7a3a19e > > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml > 902c421 > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml > 2168868 > > ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/HiveLog4jMetricsActionTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/50532/diff/ > > > Testing > ------- > > Added unit tests. > Tested EU from HDP 2.4 to 2.5. > Tested RU from HDP 2.3 to 2.5 > > > Thanks, > > Aravindan Vijayan > >