-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50532/#review144095
-----------------------------------------------------------




ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/HiveLog4jMetricsAction.java
 (lines 80 - 81)
<https://reviews.apache.org/r/50532/#comment210096>

    This will be huge and probably not look right to the command output, which 
is available on the UI.  Use some text saying something like "Updated 
hive-log4j/content to WARN on metrics"
    
    Make the text as descriptive as you like, as long as you don't put full 
context of log4j.properties.


- Nate Cole


On July 28, 2016, 7:07 p.m., Aravindan Vijayan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50532/
> -----------------------------------------------------------
> 
> (Updated July 28, 2016, 7:07 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Jonathan 
> Hurley, Nate Cole, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-17949
>     https://issues.apache.org/jira/browse/AMBARI-17949
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> In hive-log4j content, the following needs to be added during HDP upgrades to 
> 2.5.
> 
> # Silence HadoopMetrics2Reporter INFO logs
> log4j.logger.com.github.joshelser.dropwizard.metrics.hadoop=WARN,DRFA
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/HiveLog4jMetricsAction.java
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
>  7197e29 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> 7a3a19e 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
>  902c421 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> 2168868 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/HiveLog4jMetricsActionTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/50532/diff/
> 
> 
> Testing
> -------
> 
> Added unit tests.
> Tested EU from HDP 2.4 to 2.5.
> Tested RU from HDP 2.3 to 2.5
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Reply via email to