-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51078/#review145735
-----------------------------------------------------------




ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/params.py
 (line 173)
<https://reviews.apache.org/r/51078/#comment212101>

    This code is using hive_server_host[0] while earlier the code in 
spark_service.py was using socket.getfqdn() implying getting the keytab for the 
hive service on the STS machine. 
    
    I am wonder which is the right behavior. If every machine on the cluster 
has its own specific hive service keytab then the old approach is correct since 
it will use the hive service keytab for that machine.
    
    Using hive_server_host[0] may try to use keytab for service on a different 
machine. Will that be available? What if there are multipe HS2 in the cluster?


- bikassaha


On Aug. 13, 2016, 8:45 p.m., Jeff Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51078/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2016, 8:45 p.m.)
> 
> 
> Review request for Ambari and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18142
>     https://issues.apache.org/jira/browse/AMBARI-18142
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Should define keytab/principle for spark thrift server in its configuration 
> file 'spark-thrift-sparkconf'
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/configuration/spark-env.xml
>  832a8f5 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/params.py
>  e38316b 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/spark_service.py
>  704af68 
>   ambari-server/src/main/resources/common-services/SPARK/1.4.1/kerberos.json 
> 21ba259 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-env.xml
>  5a3edef 
>   ambari-server/src/main/resources/common-services/SPARK2/2.0.0/kerberos.json 
> 3aafb75 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/params.py
>  c89a302 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/spark_service.py
>  834871d 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/kerberos.json 
> ea2cf52 
> 
> Diff: https://reviews.apache.org/r/51078/diff/
> 
> 
> Testing
> -------
> 
> Tested manually.
> 
> 
> Thanks,
> 
> Jeff Zhang
> 
>

Reply via email to