-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51354/
-----------------------------------------------------------
Review request for Ambari, Hayat Behlim, Dharmesh Makwana, Oliver Szabo, and
Robert Nettleton.
Bugs: AMBARI-18246
https://issues.apache.org/jira/browse/AMBARI-18246
Repository: ambari
Description
-------
- long methods were broken up to smaller independent parts
- narrowed the scope of too widely defined variables
- fixed visibilities of the methods/fields
- converted constants / enums to use java conventions for names
- maximum line length is 120 characters, fixed unnecessary short lines
- rearranged the functions so that they follow the order of the lifecycle of
these components
- refactored some overcomplicated parts
- removed unused codes
Diffs
-----
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeeder.java
373d743
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/Filter.java
ab371f1
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/Input.java
5feb9c4
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputMgr.java
b18c9b0
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputSimulate.java
5ba56a5
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputMgr.java
0a6b7fa
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputS3File.java
e95f8df
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/AliasUtil.java
a92ba29
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/FileUtil.java
ec26a88
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/LogFeederUtil.java
32029ff
ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/input/InputFileTest.java
42e81da
Diff: https://reviews.apache.org/r/51354/diff/
Testing
-------
Tested on local cluster
Thanks,
Miklos Gergely
