> On Aug. 30, 2016, 9:43 p.m., Jaimin Jetly wrote: > > ambari-web/app/templates/main/alerts/manage_alert_notifications_popup.hbs, > > lines 47-56 > > <https://reviews.apache.org/r/51540/diff/1/?file=1488873#file1488873line47> > > > > Is hidding this section of code when "selectedAlertNotificaion.enabled > > is true" intentional ?
Yes, the Edit and Duplicate options should be visible only when the alert notification is enabled. If it is disabled, then only "Enable" option is visible. - Vivek Ratnavel ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51540/#review147365 ----------------------------------------------------------- On Aug. 30, 2016, 9:24 p.m., Vivek Ratnavel Subramanian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51540/ > ----------------------------------------------------------- > > (Updated Aug. 30, 2016, 9:24 p.m.) > > > Review request for Ambari, Jaimin Jetly, Zhe (Joe) Wang, and Yusaku Sako. > > > Bugs: Ambari-18281 > https://issues.apache.org/jira/browse/Ambari-18281 > > > Repository: ambari > > > Description > ------- > > Add an option to Enable/ Disable alert notifications in Manage Notifications > popup. > > > Diffs > ----- > > > ambari-web/app/controllers/main/alerts/manage_alert_notifications_controller.js > 1de15a6 > ambari-web/app/mappers/alert_notification_mapper.js 95e2362 > ambari-web/app/messages.js b216918 > ambari-web/app/models/alerts/alert_notification.js c2d7570 > ambari-web/app/styles/modal_popups.less 762ea46 > ambari-web/app/templates/main/alerts/manage_alert_notifications_popup.hbs > 19f9ca3 > ambari-web/app/views/main/alerts/manage_alert_notifications_view.js 5b476a3 > > Diff: https://reviews.apache.org/r/51540/diff/ > > > Testing > ------- > > Verified manually. > Ambari-web unit tests pass. > 30014 tests complete (26 seconds) > 154 tests pending > > > Thanks, > > Vivek Ratnavel Subramanian > >
