----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51540/#review147460 -----------------------------------------------------------
Ship it! Ship It! - Jaimin Jetly On Aug. 31, 2016, 1:51 a.m., Vivek Ratnavel Subramanian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51540/ > ----------------------------------------------------------- > > (Updated Aug. 31, 2016, 1:51 a.m.) > > > Review request for Ambari, Jaimin Jetly, Zhe (Joe) Wang, and Yusaku Sako. > > > Bugs: Ambari-18281 > https://issues.apache.org/jira/browse/Ambari-18281 > > > Repository: ambari > > > Description > ------- > > Add an option to Enable/ Disable alert notifications in Manage Notifications > popup. > > > Diffs > ----- > > > ambari-web/app/controllers/main/alerts/manage_alert_notifications_controller.js > 1de15a6 > ambari-web/app/mappers/alert_notification_mapper.js 95e2362 > ambari-web/app/messages.js b216918 > ambari-web/app/models/alerts/alert_notification.js c2d7570 > ambari-web/app/styles/modal_popups.less 762ea46 > ambari-web/app/templates/main/alerts/manage_alert_notifications_popup.hbs > 19f9ca3 > ambari-web/app/views/main/alerts/manage_alert_notifications_view.js 5b476a3 > ambari-web/test/views/main/alerts/manage_alert_notifications_view_test.js > cebee96 > > Diff: https://reviews.apache.org/r/51540/diff/ > > > Testing > ------- > > Verified manually. > Ambari-web unit tests pass. > 30014 tests complete (26 seconds) > 154 tests pending > > > File Attachments > ---------------- > > v1 > > https://reviews.apache.org/media/uploaded/files/2016/08/31/ad971a3a-3430-4caa-9e7f-df60cc75872c__AMBARI-18281.v1.patch > > > Thanks, > > Vivek Ratnavel Subramanian > >
