+ Jayush

Hey Nate,

It has not yet been committed.

@Jayush: Should we commit it to trunk only or to 2.5 as well?

Bence

From: Nate Cole <[email protected]<mailto:[email protected]>> 
on behalf of Nate Cole <[email protected]<mailto:[email protected]>>
Reply-To: Nate Cole <[email protected]<mailto:[email protected]>>
Date: Wednesday, August 31, 2016 at 22:34
To: Sebastian Toader <[email protected]<mailto:[email protected]>>, 
Nate Cole <[email protected]<mailto:[email protected]>>, Laszlo Puskas 
<[email protected]<mailto:[email protected]>>, Jonathan Hurley 
<[email protected]<mailto:[email protected]>>, Sumit Mohanty 
<[email protected]<mailto:[email protected]>>, Oliver Szabo 
<[email protected]<mailto:[email protected]>>
Cc: default <[email protected]<mailto:[email protected]>>, Ambari 
<[email protected]<mailto:[email protected]>>
Subject: Re: Review Request 51370: DB consistency check should tolerate 
services with no configuration

This is an automatically generated e-mail. To reply, visit: 
https://reviews.apache.org/r/51370/


What's the state of this review?  If it's pushed can it be closed?


- Nate Cole


On August 25th, 2016, 7:26 a.m. EDT, Balázs Bence Sári wrote:

Review request for Ambari, Jonathan Hurley, Laszlo Puskas, Nate Cole, Oliver 
Szabo, Sumit Mohanty, and Sebastian Toader.
By Balázs Bence Sári.

Updated Aug. 25, 2016, 7:26 a.m.

Bugs: AMBARI-18254<https://issues.apache.org/jira/browse/AMBARI-18254>
Repository: ambari
Description

Services with no configs triggered an error in DB consistency checker during 
Ambari server start. Since the Microsoft R mpack has no configs at all, 
installing the Microsoft R mpack would result in error during server start. 
This patch lowers the check to warning level.


Testing

  1.  Tested manually

  2.  Wrote a new unit tests

  3.  All unit tests in ambari-servers passed.



Diffs

  *   
ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
 (36a2d99)
  *   
ambari-server/src/test/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelperTest.java
 (a7c77e1)

View Diff<https://reviews.apache.org/r/51370/diff/>

Reply via email to