> On Sept. 6, 2016, 1:51 p.m., Laszlo Puskas wrote:
> > ambari-server/src/test/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelperTest.java,
> >  line 300
> > <https://reviews.apache.org/r/51370/diff/1/?file=1483764#file1483764line300>
> >
> >     Use annotations to create mocks where possible. EasyMockRule should be 
> > used for that to work.
> >     (As a reference check the TopologyManagerTest - follow the usage only, 
> > not the tests ;P)

This will not work on static fields.

(Btw, I would support refactoring the database consistency checker along with 
its tests, but this should have its own Jira not piggybacked on this one. Given 
the deadline for mpacks, I would like to keep focused on the original scope of 
the Jiras and not creep in any extra efforts that are not necessary. This 
ticket is meant to be a small small change and the new test copies the layout 
of existing tests.)


- Balázs Bence


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51370/#review147830
-----------------------------------------------------------


On Aug. 25, 2016, 11:26 a.m., Balázs Bence Sári wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51370/
> -----------------------------------------------------------
> 
> (Updated Aug. 25, 2016, 11:26 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Laszlo Puskas, Nate Cole, Oliver 
> Szabo, Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-18254
>     https://issues.apache.org/jira/browse/AMBARI-18254
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Services with no configs triggered an error in DB consistency checker during 
> Ambari server start. Since the Microsoft R mpack has no configs at all, 
> installing the Microsoft R mpack would result in error during server start. 
> This patch lowers the check to warning level.
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
>  36a2d99 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelperTest.java
>  a7c77e1 
> 
> Diff: https://reviews.apache.org/r/51370/diff/
> 
> 
> Testing
> -------
> 
> 1. Tested manually
> 2. Wrote a new unit tests
> 3. All unit tests in ambari-servers passed.
> 
> 
> Thanks,
> 
> Balázs Bence Sári
> 
>

Reply via email to