> On Вер. 5, 2016, 9:41 після полудня, Sid Wagle wrote: > > ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java, > > line 328 > > <https://reviews.apache.org/r/51629/diff/1/?file=1490884#file1490884line328> > > > > This does't look right, the component needs to be on the smae host as > > well. Wouldn't this always return true on a multi-host cluster ?
Sorry, i thought about that but forgot to add it. - Vitalyi ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51629/#review147782 ----------------------------------------------------------- On Вер. 6, 2016, 12:06 після полудня, Vitalyi Brodetskyi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51629/ > ----------------------------------------------------------- > > (Updated Вер. 6, 2016, 12:06 після полудня) > > > Review request for Ambari, Andrew Onischuk, Dmytro Sen, and Sid Wagle. > > > Bugs: AMBARI-18309 > https://issues.apache.org/jira/browse/AMBARI-18309 > > > Repository: ambari > > > Description > ------- > > Add db consistency check for hostcomponent tables, for each component we > should have only one state. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java > f302b8b > > ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyChecker.java > 535d74f > > ambari-server/src/test/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelperTest.java > 4663310 > > Diff: https://reviews.apache.org/r/51629/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Vitalyi Brodetskyi > >
