----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51629/#review148045 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java (line 332) <https://reviews.apache.org/r/51629/#comment215417> The variable name is "GET_HOST_COMPONENT_STATE_DUPLICATES_QUERY" so I interpreted this as any pairs that are dups of the tuple <component, host>, in which the state is also different. But you're right that the component and host should only appear once. - Alejandro Fernandez On Sept. 6, 2016, 10:29 p.m., Vitalyi Brodetskyi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51629/ > ----------------------------------------------------------- > > (Updated Sept. 6, 2016, 10:29 p.m.) > > > Review request for Ambari, Andrew Onischuk, Dmytro Sen, and Sid Wagle. > > > Bugs: AMBARI-18309 > https://issues.apache.org/jira/browse/AMBARI-18309 > > > Repository: ambari > > > Description > ------- > > Add db consistency check for hostcomponent tables, for each component we > should have only one state. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java > f302b8b > > ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyChecker.java > 535d74f > > ambari-server/src/test/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelperTest.java > 4663310 > > Diff: https://reviews.apache.org/r/51629/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Vitalyi Brodetskyi > >
