----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51685/#review148010 -----------------------------------------------------------
Fix it, then Ship it! The change looks fine to me, just need a clarification as to why this is being logged in addition to being available via the REST API. Thanks. ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java (line 499) <https://reviews.apache.org/r/51685/#comment215365> Why is this being logged? It seems to me that you should be able to just GET the Blueprint back from the Ambari REST API, so logging this here seems redundant, especially considering that we generally don't log pieces of the Blueprint during the Blueprint POST. Is this section returned properly via the Blueprint GET call? - Robert Nettleton On Sept. 7, 2016, 2:14 a.m., Nahappan Somasundaram wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51685/ > ----------------------------------------------------------- > > (Updated Sept. 7, 2016, 2:14 a.m.) > > > Review request for Ambari, Sumit Mohanty and Sid Wagle. > > > Bugs: AMBARI-18328 > https://issues.apache.org/jira/browse/AMBARI-18328 > > > Repository: ambari > > > Description > ------- > > AMBARI-18328: Blueprints: Log "setting" section of blueprint in ambari server > log file > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java > de998cea801dba4b554255b209d20fb61bca36cc > > Diff: https://reviews.apache.org/r/51685/diff/ > > > Testing > ------- > > ** Manual Testing ** > Deployed a VM with the latest trunk build and patched ambari-server JAR with > the one from the local build. Ran a blueprint deployed and verified that the > *settings* section of the blueprint was logged in > /var/log/ambari-server/ambari-server.log. > > > Thanks, > > Nahappan Somasundaram > >
