> On Sept. 7, 2016, 6:58 a.m., Robert Nettleton wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java,
> >  line 499
> > <https://reviews.apache.org/r/51685/diff/1/?file=1492705#file1492705line499>
> >
> >     Why is this being logged? 
> >     
> >     It seems to me that you should be able to just GET the Blueprint back 
> > from the Ambari REST API, so logging this here seems redundant, especially 
> > considering that we generally don't log pieces of the Blueprint during the 
> > Blueprint POST. 
> >     
> >     Is this section returned properly via the Blueprint GET call?

Looking at the ambari logs, we want to figure out the auto start configuration, 
without having to query the cluster. I agree that we don't log pieces of the 
blueprint. The *settings* section is typically very small so logging it will 
not take up much space in the logs. 

https://issues.apache.org/jira/browse/AMBARI-18332 tracks the API fix.


- Nahappan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51685/#review148010
-----------------------------------------------------------


On Sept. 6, 2016, 7:14 p.m., Nahappan Somasundaram wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51685/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2016, 7:14 p.m.)
> 
> 
> Review request for Ambari, Sumit Mohanty and Sid Wagle.
> 
> 
> Bugs: AMBARI-18328
>     https://issues.apache.org/jira/browse/AMBARI-18328
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> AMBARI-18328: Blueprints: Log "setting" section of blueprint in ambari server 
> log file
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java
>  de998cea801dba4b554255b209d20fb61bca36cc 
> 
> Diff: https://reviews.apache.org/r/51685/diff/
> 
> 
> Testing
> -------
> 
> ** Manual Testing **
> Deployed a VM with the latest trunk build and patched ambari-server JAR with 
> the one from the local build. Ran a blueprint deployed and verified that the 
> *settings* section of the blueprint was logged in 
> /var/log/ambari-server/ambari-server.log.
> 
> 
> Thanks,
> 
> Nahappan Somasundaram
> 
>

Reply via email to