----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51815/#review148721 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/state/DependencyConditionInfo.java (line 103) <https://reviews.apache.org/r/51815/#comment216224> do you support other type of checks ? such as the property has to be a certain value ? ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml (line 55) <https://reviews.apache.org/r/51815/#comment216221> this is already a subsection of "dependency", it can just be called "conditions" ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml (line 56) <https://reviews.apache.org/r/51815/#comment216222> same here, no need to reiterate it's for "dependency" ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml (line 58) <https://reviews.apache.org/r/51815/#comment216223> what does "<property>dfs.nameservices</property>" mean in this conditional check? as a negative test, what if a user manually added the property to hdfs-site.xml ? - Di Li On Sept. 12, 2016, 5:45 p.m., Amruta Borkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51815/ > ----------------------------------------------------------- > > (Updated Sept. 12, 2016, 5:45 p.m.) > > > Review request for Ambari, Di Li, Juanjo Marron, Laszlo Puskas, and Robert > Nettleton. > > > Bugs: AMBARI-18355 > https://issues.apache.org/jira/browse/AMBARI-18355 > > > Repository: ambari > > > Description > ------- > > Currently stack definitions do not list conditional dependencies, adding > those to the stack definitions would make it easy to validate errors in case > of blueprint deployment. Please refer to document attached to Jira > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/state/DependencyConditionInfo.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/state/DependencyInfo.java > e3db662 > > ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidatorImpl.java > a5f33ff > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml > 65d166a > > ambari-server/src/test/java/org/apache/ambari/server/topology/BlueprintValidatorImplTest.java > b1de8ef > > Diff: https://reviews.apache.org/r/51815/diff/ > > > Testing > ------- > > Written Junit test cases. Perfomred manual testing to check the Namenode HA > component dependency. Was able to proceed with the installation for valid > blueprint. and got validation error message while registering blueprint when > the Blueprint did not satisfy the conditional dependencies. > > > Thanks, > > Amruta Borkar > >
