-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51815/#review150734
-----------------------------------------------------------


Fix it, then Ship it!




Overall, the patch looks fine to me.  I've just added a few minor issues that 
might be useful to consider.  

Thanks again for providing this patch!


ambari-server/src/main/java/org/apache/ambari/server/state/DependencyConditionInfo.java
 (line 51)
<https://reviews.apache.org/r/51815/#comment218789>

    Minor issue:
    
    Since the PropertyValueEquals condition also requires that the property 
exists, perhaps this implementation should inherit from 
PropertyExistsDependencyCondition? 
    
    This might be worth exploring, just from a code maintenance perspective.



ambari-server/src/main/java/org/apache/ambari/server/state/DependencyConditionInfo.java
 (line 53)
<https://reviews.apache.org/r/51815/#comment218790>

    Minor issue: 
    
    It might be a good idea to make these fields final, since they seem to be 
immutable fields in these classes.



ambari-server/src/main/java/org/apache/ambari/server/state/DependencyConditionInfo.java
 (line 57)
<https://reviews.apache.org/r/51815/#comment218791>

    Minor Suggestion(and I won't add an issue here):
    
    If assertions were added to the constructor to verify that the parameters 
are not null, then the logic in the isResolved() methods could be simplified a 
bit.


- Robert Nettleton


On Sept. 20, 2016, 11:18 p.m., Amruta Borkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51815/
> -----------------------------------------------------------
> 
> (Updated Sept. 20, 2016, 11:18 p.m.)
> 
> 
> Review request for Ambari, Shantanu Mundkur, Di Li, Jayush Luniya, Juanjo  
> Marron, Laszlo Puskas, and Robert Nettleton.
> 
> 
> Bugs: AMBARI-18355
>     https://issues.apache.org/jira/browse/AMBARI-18355
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Currently stack definitions do not list conditional dependencies, adding 
> those to the stack definitions would make it easy to validate errors in case 
> of blueprint deployment. Please refer to document attached to Jira
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/DependencyConditionInfo.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/DependencyInfo.java
>  e3db662 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidatorImpl.java
>  a5f33ff 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml 
> 65d166a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/BlueprintValidatorImplTest.java
>  b1de8ef 
> 
> Diff: https://reviews.apache.org/r/51815/diff/
> 
> 
> Testing
> -------
> 
> Written Junit test cases. Perfomred manual testing to check the Namenode HA 
> component dependency. Was able to proceed with the installation for valid 
> blueprint. and got validation error message while registering blueprint when 
> the Blueprint did not satisfy the conditional dependencies.
> 
> 
> Thanks,
> 
> Amruta Borkar
> 
>

Reply via email to